Checks: Add failed mesh elements/sides to debug mesh - #160
Merged
Conversation
Collaborator
Author
|
@scopplestone Currently, we do not create a separate |
kopperp
force-pushed
the
improvement.check.output
branch
3 times, most recently
from
August 16, 2026 12:35
0c48750 to
247c413
Compare
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
scopplestone
approved these changes
Sep 2, 2026
Collaborator
I would not add a separate container and instead filter the normal output |
Previously, CheckOrient() was called before GenerateSides(), so elem.sides did not exist. After moving CheckOrient() back, align better with PyHOPE internal data structure
kopperp
force-pushed
the
improvement.check.output
branch
from
September 2, 2026 18:54
247c413 to
949d502
Compare
scopplestone
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If any element or side fails a mesh check, add it to a separate
Volume [Error]/Surface [Error]grid in the XDMF debug mesh.Additionally, improve the alignment of the CheckOrient logic. Previously, CheckOrient() was called before GenerateSides(), so elem.sides did not exist. After moving CheckOrient() backwards in the call structure, align better with PyHOPE internal data structure.
Closes #157